Creating PULL REQUESTS

O

Qubits of DPK

March 22, 2026

Core Open Source
Go to your GitHub repo and follow these steps:
1. Go to: https://github.com/apache/fineract
2. You'll see a yellow banner saying "Your recently pushed branch: feature/FINERACT-2549-migrate-loanproduct-shortname-test" — click "Compare & pull request"
3. Fill in:
  • Base branch: develop
  • Title: FINERACT-2549: Migrate LoanProductShortNameValidationTest from RestAssured to feign client
4. In the description box paste:
markdown
QUBITS OF DPK
1## What this PR does
2
3Migrates `LoanProductShortNameValidationTest` from the deprecated RestAssured-based approach
4to the typed fineract-client-feign client, as part of FINERACT-2549.
5
6## Changes
7
8- **LoanProductShortNameValidationTest**: Removed RestAssured `requestSpec`/`responseSpec`
9  fields, `@BeforeEach` setup, and `LoanTransactionHelper` dependency. Replaced with direct
10  feign client calls using `FineractClientHelper` and `Calls.ok()`. The expected 403 duplicate
11  short name error is now asserted using `assertThrows(CallFailedRuntimeException.class, ...)`.
12
13## Checklist
14- [x] No RestAssured imports remaining
15- [x] GPG signed commit
16- [x] `spotlessApply` run
17- [x] Compiles successfully
18- [x] Relates to FINERACT-2549 (does not close it)
5. Click "Create pull request"
Tell me the PR number once it's created.
or via gh cli
bash
QUBITS OF DPK
1gh pr create --repo apache/fineract --title "FINERACT-2549: Migrate LoanProductShortNameValidationTest from RestAssured to feign client" --body "$(cat <<'EOF'
2## What this PR does
3
4Migrates `LoanProductShortNameValidationTest` from the deprecated RestAssured-based approach to the typed fineract-client-feign client, as part of [FINERACT-2549](https://issues.apache.org/jira/browse/FINERACT-2549).
5
6## Changes
7
8- **LoanProductShortNameValidationTest**: Removed RestAssured `requestSpec`/`responseSpec` fields, `@BeforeEach` setup, and `LoanTransactionHelper` dependency. Replaced with direct feign client calls using `FineractClientHelper` and `Calls.ok()`. The expected 403 duplicate short name error is now asserted using `assertThrows(CallFailedRuntimeException.class, ...)`.
9
10## Checklist
11
12- [x] No RestAssured imports remaining
13- [x] GPG signed commit
14- [x] `spotlessApply` run
15- [x] Compiles successfully
16- [x] Relates to FINERACT-2549 (does not close it)
17EOF
18)"